-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: make io.rst utf8 only #5926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe this can solve the windows building issue (I will also test), but aside: do we want this in the docs? Because the example by itself does work, it's only the building that does not work (as far as I understand). |
I think we want users/contributors to be able to build the docs, yeah. Even if they're on windows/diff locale It took a lot of effort to get pandas to play nice wth unicode and one lesson learned is not |
I tried it, and it does not solve the issue. And in retrospect, that is maybe also logical: the problem in windows is in the building of the rst with unicode to html, and it is the output generated by the code example which causes this. With your changes, the output of the code example still contains special characters (which is also the point of the code example), and so causes the build on windows to stop. I think @JanSchulz had another approach as a kind of hack: something along the lines of #5142 (comment). I also vaguely remember that the issue was fixed when using ipython's version of the ipython directive, but I should check that. |
Then I misunderstood the issue. There is a definite difference:
and in the case of python's "encoding utf8" premable that makes all the difference. Thanks for testing. |
btw, there was some |
See also here #5142 (comment). There was indeed a |
I will try out the other PR with your rebase. |
I'm seriously skimming past all the important bits today :), sorry. |
#5142
@JanSchulz , can you test whether this solves the problem for you?