BUG: dropna dtype comp issue related (GH5815) #5820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added a commit
that referenced
this pull request
Jan 2, 2014
BUG: dropna dtype comp issue related (GH5815)
| @@ -3954,7 +3954,7 @@ def count(self, axis=0, level=None, numeric_only=False): | |||
| else: | |||
| result = notnull(frame).sum(axis=axis) | |||
|
|
|||
| return result | |||
| return result.astype('int64') | |||
There was a problem hiding this comment.
just for my clarity - why is it important that this return in64 rather than int32 or whatever local build desires? Is that our common practice?
There was a problem hiding this comment.
should always be int64 as it returns a series
I think the sum of the boolean (when u isnull it returns boolean) when summed goes to int32 on 32 platforms
not really well defined what it should do
but that is generally a user decision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes dtype issue on 32-bit, related #5815