Skip to content

BUG: dropna dtype comp issue related (GH5815) #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2014
+1 −1
Merged

BUG: dropna dtype comp issue related (GH5815) #5820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3954,7 +3954,7 @@ def count(self, axis=0, level=None, numeric_only=False):
else:
result = notnull(frame).sum(axis=axis)

return result
return result.astype('int64')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my clarity - why is it important that this return in64 rather than int32 or whatever local build desires? Is that our common practice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should always be int64 as it returns a series
I think the sum of the boolean (when u isnull it returns boolean) when summed goes to int32 on 32 platforms
not really well defined what it should do
but that is generally a user decision


def _count_level(self, level, axis=0, numeric_only=False):
if numeric_only:
Expand Down