-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: perf issue with dropna on frame #5815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PERF: perf issue with dropna on frame
Broke builds on SPARC. |
just 32bit vs. 64bit error. This is why it will be very nice when we can get an 32 bit build going on Travis/somewhere else. |
What does "just an error" mean? It's possible to setup a 32bit environment on travis, it's just annoying to develop the scripts re versioning, yeah. go ahead and open a PR. |
...rather then 0.14 or 0.13.1, we can't know. |
It would be bad if we had 50 versions prefixed "0.14.0dev-" after which we release a 0.13.1 |
@y-p there's no 32 bit build allowed on Travis. I see your point on 0.14 vs. 0.13.1 - probably just needs to say "dev" in the name instead. |
and "just an error", I mean that issues with which int dtype should come up in 32 bit crop up a lot because we aren't regularly testing on 32 bit machines. I'll put up a PR about versioning tomorrow once I figure out how directory names/version names are set... |
@jtratner, who can stop you from installing a 32bit python every run? it may even be relatively painless Go for it, I'm now convinced this versioning stuff is important enough. |
Ooh! Interesting idea for sure... |
I think lets rename to 0.13.1 then no confusion if we later change it to 0.14 also makes the git version look fine for now (if it has dev in it) |
re running 32-bit - looks possible but tricky http://askubuntu.com/questions/60094/compile-32-bit-on-64-bitsystem ironically if sparc builds are automatic at least easy to catch almost always these are just test dtype issue - easy to fix |
fixed by #5820 |
I think a 64bit gcc can emit 32 bit code without too much trouble, would need to install 32bit libc Don't put effort into this for now. I've been slowly working on something to improve our CI situation. @jreback, i'm sold, fix the versions. I won't say a word, honest. |
@jtratner change to 0.13.1 for now ok? can always change later back to 0.14 it's hard to say until we really release into the wild if we r going to need 0.13.1 should be somewhat straightforward to actually release |
Fine with me |
took out the apply on
count
and just compute directly