BUG: 7023 allow style when using error bars #57967

thetestspecimen · 2024-03-22T19:27:02Z

closes DF Plots: Error bars don't allow to set styles #7023
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/v3.0.0.rst file if fixing a bug or adding a new feature.

If the 'style' parameter is passed to the DataFrame's 'plot' method at the same time as error bar parameters 'yerr' or 'xerr' (or both), then the 'style' parameter is not applied to the plot. For example, something like this:

ax = df.plot(xerr=err_x, yerr=err_y, style='or:')

will result in the marker style, color and line style being ignored.

This PR passes the style parameter to the plot.

The comments in the bug report mention a work around not working with 'subplots'. As such, I have created scenario in the tests that confirm this fix will also work for subplots.

Note: This fix is identical to that previously provided by @GLeurquin (PR #40816), but it went stale and was closed. I have basically added the missing tests that were requested, and never provided.

Aloqeely · 2024-04-20T14:48:49Z

pandas/plotting/_matplotlib/core.py

@@ -974,6 +974,9 @@ def _plot(
                kwds["xerr"] = np.array(kwds.get("xerr"))
            if "yerr" in kwds:
                kwds["yerr"] = np.array(kwds.get("yerr"))
+            # GH 7023 allow setting plot style when using errorbars


Suggested change

# GH 7023 allow setting plot style when using errorbars

# GH 7023

Aloqeely · 2024-04-20T14:51:12Z

Thanks for the PR! Sorry that this hasn't been reviewed yet. In the meantime can you fix the merge conflict?
cc @datapythonista

Aloqeely · 2024-04-20T14:57:38Z

doc/source/whatsnew/v3.0.0.rst

@@ -372,7 +372,7 @@ Period

 Plotting
 ^^^^^^^^
-
+- Bug in :meth:`MPLPlot._plot` ignoring parameter ``style`` when using error bar parameters ``yerr`` or ``xerr`` (:issue:`7023`)


Same comment as in original PR, "Can you describe this in a user-facing way"?
I.E. the method that the user uses is not MPLPlot._plot but rather DataFrame.plot or Series.plot

thetestspecimen · 2024-04-20T19:05:25Z

Thanks for the PR! Sorry that this hasn't been reviewed yet. In the meantime can you fix the merge conflict? cc @datapythonista

No problem at all.

I will take a look at your comments and get it up to date as soon as I get a minute (probably tomorrow).

thetestspecimen · 2024-04-21T11:29:29Z

Apparently 1 check fails in relation to Unit Tests / Numpy Dev (pull_request) , but I'm not sure it has anything to do with the code:

[2024-04-21T10:31:57.779Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2024-04-21T10:31:57.779Z] ['info'] Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the `-Z` flag

Is there something you need me to do, or a way I can re-run the checks?

Aloqeely · 2024-04-21T18:51:54Z

This is what I'm seeing:

FAILED pandas/tests/extension/test_sparse.py::TestSparseArray::test_isna_returns_copy[0-isna] - ValueError: assignment destination is read-only
FAILED pandas/tests/extension/test_sparse.py::TestSparseArray::test_isna_returns_copy[0-notna] - ValueError: assignment destination is read-only
FAILED pandas/tests/extension/test_sparse.py::TestSparseArray::test_isna_returns_copy[nan-isna] - ValueError: assignment destination is read-only
FAILED pandas/tests/extension/test_sparse.py::TestSparseArray::test_isna_returns_copy[nan-notna] - ValueError: assignment destination is read-only
FAILED pandas/tests/indexes/test_base.py::TestIndex::test_drop_by_str_label[string] - KeyError: "['SOMEBIGLONGSTRING'] not found in axis"
FAILED pandas/tests/arrays/test_datetimelike.py::TestDatetimeArray::test_array_interface[D] - AssertionError
FAILED pandas/tests/arrays/test_datetimelike.py::TestDatetimeArray::test_array_interface[B] - AssertionError
FAILED pandas/tests/arrays/test_datetimelike.py::TestDatetimeArray::test_array_interface[W] - AssertionError
FAILED pandas/tests/arrays/test_datetimelike.py::TestDatetimeArray::test_array_interface[ME] - AssertionError
FAILED pandas/tests/arrays/test_datetimelike.py::TestDatetimeArray::test_array_interface[QE] - AssertionError
FAILED pandas/tests/arrays/test_datetimelike.py::TestDatetimeArray::test_array_interface[YE] - AssertionError
FAILED pandas/tests/arrays/test_datetimelike.py::TestTimedeltaArray::test_array_interface - AssertionError
= 12 failed, 171032 passed, 25300 skipped, 892 xfailed, 78 xpassed in 718.59s (0:11:58) =

I don't know of a better way, but, you can merge with main if you want to re-run the checks

Aloqeely · 2024-04-21T19:45:16Z

Update: this failure seems to be happening on all PRs, you have nothing to worry about!

thetestspecimen · 2024-04-21T21:01:48Z

Update: this failure seems to be happening on all PRs, you have nothing to worry about!

Thanks for letting me know. I thought it was a bit strange.

Let me know if you need me to force the checks to re-run (and when).

Aloqeely · 2024-05-06T20:33:20Z

I understand you requested my review but I don't know much about the plotting code to help review this, maybe @mroeschke can help

mroeschke · 2024-05-07T17:21:33Z

Unfortunately we don't have anyone on the core team who really understands the plotting code anymore. I can try looking later to give a high level review

thetestspecimen · 2024-05-07T19:52:45Z

Unfortunately we don't have anyone on the core team who really understands the plotting code anymore. I can try looking later to give a high level review

No problem. The code change is very small, and was actually originally provided in PR #40816 . I have just added the tests that were missing.

github-actions · 2024-06-07T00:05:57Z

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

thetestspecimen · 2024-06-07T05:45:02Z

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

I will update this soon to keep it available.

mroeschke · 2024-07-05T17:23:14Z

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

thetestspecimen · 2024-07-07T09:01:30Z

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke I have merged the main branch in and pushed it to my fork of pandas. I suspect you will need to reopen before it gets pulled across here?

thetestspecimen added 5 commits March 20, 2024 23:14

Fix BUG-7023 allow style when using errorbars

a4a8ea7

Merge remote-tracking branch 'upstream/main' into 7023_error_bars

d55b429

Tests for BUG-7023 allow style when using errorbars

da9dae8

Merge remote-tracking branch 'upstream/main' into 7023_error_bars

710c54a

Docs for BUG-7023 allow style when using errorbars

72fd7e5

Aloqeely reviewed Apr 20, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 7023_error_bars

e6777e1

thetestspecimen added 4 commits April 21, 2024 12:46

Merge remote-tracking branch 'upstream/main' into 7023_error_bars

8472ef3

Update whatsnew to use correct docs reference

7cbb7cc

Remove description from GitHub reference

34d99ec

Precommit - sort whatsnew entries alphabetically

b6b8d93

Merge remote-tracking branch 'upstream/main' into 7023_error_bars

711d620

thetestspecimen requested a review from Aloqeely April 28, 2024 11:17

github-actions bot added the Stale label Jun 7, 2024

Merge remote-tracking branch 'upstream/main' into 7023_error_bars

0737ae0

mroeschke closed this Jul 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: 7023 allow style when using error bars #57967

BUG: 7023 allow style when using error bars #57967

thetestspecimen commented Mar 22, 2024

Aloqeely Apr 20, 2024

Aloqeely commented Apr 20, 2024

Aloqeely Apr 20, 2024

thetestspecimen commented Apr 20, 2024

thetestspecimen commented Apr 21, 2024

Aloqeely commented Apr 21, 2024

Aloqeely commented Apr 21, 2024

thetestspecimen commented Apr 21, 2024

Aloqeely commented May 6, 2024

mroeschke commented May 7, 2024

thetestspecimen commented May 7, 2024

github-actions bot commented Jun 7, 2024

thetestspecimen commented Jun 7, 2024

mroeschke commented Jul 5, 2024

thetestspecimen commented Jul 7, 2024

	# GH 7023 allow setting plot style when using errorbars
	# GH 7023

BUG: 7023 allow style when using error bars #57967

BUG: 7023 allow style when using error bars #57967

Conversation

thetestspecimen commented Mar 22, 2024

Aloqeely Apr 20, 2024

Choose a reason for hiding this comment

Aloqeely commented Apr 20, 2024

Aloqeely Apr 20, 2024

Choose a reason for hiding this comment

thetestspecimen commented Apr 20, 2024

thetestspecimen commented Apr 21, 2024

Aloqeely commented Apr 21, 2024

Aloqeely commented Apr 21, 2024

thetestspecimen commented Apr 21, 2024

Aloqeely commented May 6, 2024

mroeschke commented May 7, 2024

thetestspecimen commented May 7, 2024

github-actions bot commented Jun 7, 2024

thetestspecimen commented Jun 7, 2024

mroeschke commented Jul 5, 2024

thetestspecimen commented Jul 7, 2024