-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: 7023 allow style when using error bars #57967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a4a8ea7
Fix BUG-7023 allow style when using errorbars
thetestspecimen d55b429
Merge remote-tracking branch 'upstream/main' into 7023_error_bars
thetestspecimen da9dae8
Tests for BUG-7023 allow style when using errorbars
thetestspecimen 710c54a
Merge remote-tracking branch 'upstream/main' into 7023_error_bars
thetestspecimen 72fd7e5
Docs for BUG-7023 allow style when using errorbars
thetestspecimen e6777e1
Merge remote-tracking branch 'upstream/main' into 7023_error_bars
thetestspecimen 8472ef3
Merge remote-tracking branch 'upstream/main' into 7023_error_bars
thetestspecimen 7cbb7cc
Update whatsnew to use correct docs reference
thetestspecimen 34d99ec
Remove description from GitHub reference
thetestspecimen b6b8d93
Precommit - sort whatsnew entries alphabetically
thetestspecimen 711d620
Merge remote-tracking branch 'upstream/main' into 7023_error_bars
thetestspecimen 0737ae0
Merge remote-tracking branch 'upstream/main' into 7023_error_bars
thetestspecimen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -974,6 +974,9 @@ def _plot( | |||||
kwds["xerr"] = np.array(kwds.get("xerr")) | ||||||
if "yerr" in kwds: | ||||||
kwds["yerr"] = np.array(kwds.get("yerr")) | ||||||
# GH 7023 allow setting plot style when using errorbars | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
if style is not None: | ||||||
kwds["fmt"] = style | ||||||
return ax.errorbar(x, y, **kwds) | ||||||
else: | ||||||
# prevent style kwarg from going to errorbar, where it is unsupported | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in original PR, "Can you describe this in a user-facing way"?
I.E. the method that the user uses is not
MPLPlot._plot
but ratherDataFrame.plot
orSeries.plot