BUG-7023 allow error bars to use style #40816
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLeurquin
commented
Apr 6, 2021
GLeurquin
commented
- closes DF Plots: Error bars don't allow to set styles #7023
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mzeitlin11
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Thanks for the pr @GLeurquin. One comment on whatsnew, plus needs tests!
| @@ -728,7 +728,7 @@ Plotting | |||
|
|
|||
| - Bug in :func:`scatter_matrix` raising when 2d ``ax`` argument passed (:issue:`16253`) | |||
| - Prevent warnings when matplotlib's ``constrained_layout`` is enabled (:issue:`25261`) | |||
| - | |||
| - Bug in :meth:`MPLPlot._plot` ignoring ``style`` when using error bars (:issue:`7023`) | |||
There was a problem hiding this comment.
Can you describe this in a user-facing way (what changes about publicly exposed pandas api?)
jreback
requested changes
Apr 9, 2021
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Closing as stale. @GLeurquin if you want to add tests and address the comment, just ping me, and more than happy to reopen. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.