CoW: Warn for inplace replace #56297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/tests/indexing/test_chaining_and_caching.py
# Conflicts: # pandas/core/internals/base.py # pandas/core/internals/blocks.py # pandas/tests/frame/methods/test_replace.py
Comment on lines
-48
to
51
| df = DataFrame({"a": [1.5, 2, 3], "b": 1.5}) | ||
| df = DataFrame({"a": [1, 2, 3], "b": 1}) | ||
| ser = df.iloc[:, 0] | ||
| # TODO(CoW-warn) should warn about updating a view for all methods | ||
| with tm.assert_cow_warning( | ||
| warn_copy_on_write and func not in ("replace", "fillna") | ||
| ): | ||
| with tm.assert_cow_warning(warn_copy_on_write and func == "replace"): | ||
| getattr(ser, func)(*args, inplace=True) |
There was a problem hiding this comment.
This is a bit fishy. The interpolate PR changed that to floats, this changes it back. But in the end this test is for ensuring there is no chained assignment warning, not about whether there is an "setting value on view" warning, will clean-up in a follow-up PR.
jorisvandenbossche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sits on the put mask pr #56168
xref #56019