TST: clean CoW chained assignment warning iloc test case #56400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,36 +35,38 @@ def test_methods_iloc_warn(using_copy_on_write): | |||
| @pytest.mark.parametrize( | |||
| "func, args", | |||
| [ | |||
| ("replace", (1, 5)), | |||
| ("replace", (4, 5)), | |||
There was a problem hiding this comment.
My understanding is that this test is just for the chained warning, so changing here to a value that is not present, so it will never trigger a "setting on view" warning at the block level (since there is nothing to replace, like for fillna there is nothing to fill), and then we only have to care about whether the chained warning is present or not
phofl
approved these changes
Dec 8, 2023
jorisvandenbossche
deleted the
cow-warnings-getitem-cache-test-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the test added in #56166, now #56297 and #56289 are merged