CoW: Warn for cases that go through putmask #56168
Conversation
There was a problem hiding this comment.
With #55522, we will also have to pass down whether we already warned about chained assignment
pandas/core/internals/base.py
Outdated
| class _AlreadyWarned: | ||
| def __init__(self): | ||
| self.warned_already = False |
There was a problem hiding this comment.
Can you add a small comment here about why such a class is needed (in contrast to a simple boolean argument)?
# Conflicts: # pandas/tests/indexing/test_chaining_and_caching.py
| df.clip(lower=2, inplace=True) | ||
| if warn_copy_on_write: | ||
| with tm.assert_cow_warning(): | ||
| df.clip(lower=2, inplace=True) |
There was a problem hiding this comment.
Should this ideally give a more specific warning about an inplace method?
Because right now this gives the general setting on a view warning
There was a problem hiding this comment.
Sure we can change the message
Co-authored-by: Joris Van den Bossche <[email protected]>
|
Yeah message sounds good, we can always iterate again if needed |
I added a small commit to do this, the other comments we can address in follow-ups |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Open for suggestions how we can improve the put mask mechanism to avoid duplicate warnings
xref #56019