CoW: Add warning for fillna #56288
Merged
CoW: Add warning for fillna #56288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/tests/indexing/test_chaining_and_caching.py
mroeschke
added
Compat
jorisvandenbossche
added
Copy / view semantics
and removed
Compat
Comment on lines
+2253
to
+2258
| if ( | ||
| not copy | ||
| and warn_copy_on_write() | ||
| and already_warned is not None | ||
| and not already_warned.warned_already | ||
| ): |
There was a problem hiding this comment.
Should this only be done in case of inplace=True? Or is that already embodied in the not copy?
There was a problem hiding this comment.
copy is only False if inplace is True
Co-authored-by: Joris Van den Bossche <[email protected]>
jorisvandenbossche
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sits on the put mask pr #56168
xref #56019