STYLE: specify encodings when opening files #52999

KetuPatel806 · 2023-04-29T10:03:18Z

closes STYLE: specify encodings when opening files #52963 #52997 (Replace STYLE: specify encodings when opening files #52963 #52997 with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.

MarcoGorelli · 2023-04-29T10:06:20Z

let's stick to one PR, please don't open a new one which does the same thing

same comments from #52997, please address them

KetuPatel806 · 2023-04-29T10:10:11Z

This is my first PR so I was making mistake next time i was more carefull for making PR

MarcoGorelli

getting there 💪

could you please:

remove b/.pre-commit-config.yaml
run pre-commit on the rest of the files you've modified?

pre-commit run --from-ref=upstream/main --to-ref=HEAD --all-files

MarcoGorelli

looks like this is it, thanks @KetuPatel806 !

MarcoGorelli · 2023-04-29T13:19:20Z

pandas/_testing/contexts.py

@@ -126,7 +126,7 @@ def ensure_clean(
    handle_or_str: str | IO = str(path)
    if return_filelike:
        kwargs.setdefault("mode", "w+b")
-        handle_or_str = open(path, **kwargs)
+        handle_or_str = open(path, **kwargs, encoding="utf-8")


apologies, looks like some tests are failing here due to

TypeError: io.open() got multiple values for keyword argument 'encoding'

we may have to do something like

handle_or_str = open(path, encoding=kwargs.get('encoding', None), **{key: value for key, value in kwargs.items() if key != 'encoding'})

, could you try this please and see if it fixes the failing tests?

Ok,I'll do it

it run the pre-commit command and i'll commit it.

MarcoGorelli

getting closer

MarcoGorelli · 2023-04-30T07:54:47Z

pandas/tests/io/xml/test_xml.py

@@ -1444,7 +1444,7 @@ def test_file_io_iterparse(datapath, parser, mode):
    filename = datapath("io", "data", "xml", "books.xml")

    funcIO = StringIO if mode == "r" else BytesIO
-    with open(filename, mode) as f:
+    with open(filename, mode, encoding="utf-8") as f:


this one's causing test failures - could we do encoding="utf-8" if mode=="r" else None?

…tion

MarcoGorelli · 2023-04-30T10:25:36Z

pandas/tests/io/xml/test_xml.py

@@ -1444,7 +1444,7 @@ def test_file_io_iterparse(datapath, parser, mode):
    filename = datapath("io", "data", "xml", "books.xml")

    funcIO = StringIO if mode == "r" else BytesIO
-    with open(filename, mode) as f:
+    with open(filename, mode, encoding="utf-8" if mode=="r" else None) as f:


still gonna have to run pre-commit on the files you've modifed though ;)

i was run it. it passed all of the hooks. only black (hook) failed it

…tion

MarcoGorelli

there's still some test failures

it may be worth parametrising over both mode and encoding. either that, or putting similar encoding='utf-8' if mode=='r' else None in the failing tests

MarcoGorelli · 2023-04-30T12:39:11Z

pandas/tests/io/xml/test_xml.py

-    with open(filename, mode) as f:
+    with open(
+        filename,
+        mode="utf-8" if mode == "r" else None,


please check this

you need to change encoding, not mode

just keep mode as it is

MarcoGorelli · 2023-04-30T18:46:07Z

this is close, a few tests left. would be great if you could finish it up, else I can add a commit on Tuesday and push this over the finish line

KetuPatel806 · 2023-05-02T11:11:42Z

can i fixes that cases or you push this over the final line???

MarcoGorelli · 2023-05-02T11:17:27Z

feel free to fix

KetuPatel806 · 2023-05-02T11:20:40Z

can you refer that test cases so i'll fix it?

MarcoGorelli · 2023-05-02T11:36:16Z

check the failing tests in the CI logs

MarcoGorelli · 2023-05-05T12:36:53Z

you'll need to fix the tests (in addition to merging upstream/main) to get this passing

KetuPatel806 · 2023-05-05T12:38:37Z

i have check the circle ci to find the error and i tired on a local to fix it.

…tion

KetuPatel806 · 2023-05-06T11:57:02Z

i try to fix read Binary mode error but if i remove the encoding then pre-commit command does not work it give me error massage called as "unspecified encoding"

…tion

KetuPatel806 · 2023-05-07T07:26:53Z

i thought it finish it up.

MarcoGorelli

should be good, thanks @KetuPatel806 !

* Changes Confirmed * Encoding Completed * Spaces Are Completed * Pre-ccommit manually completed * b.pre-commit removed * Final Commit * Some Changed reflected * test_xml Updated * Pre-commit check passed * Mode changed in xml file * mode reverted * Try to fix errors * error-checks * Fix Some errors * Unspecified-encodingFixed * final commited * simplify --------- Co-authored-by: MarcoGorelli <>

KetuPatel806 and others added 4 commits April 28, 2023 10:42

Changes Confirmed

5b482fe

Merge branch 'pandas-dev:main' into main

3302c87

Encoding Completed

c20ac6d

Spaces Are Completed

682fdf8

MarcoGorelli changed the title ~~Review it if there some errors.~~ STYLE: specify encodings when opening files Apr 29, 2023

Pre-ccommit manually completed

a5fbd47

MarcoGorelli suggested changes Apr 29, 2023

View reviewed changes

KetuPatel806 added 2 commits April 29, 2023 17:37

b.pre-commit removed

e528292

Final Commit

3d72dc3

MarcoGorelli approved these changes Apr 29, 2023

View reviewed changes

MarcoGorelli suggested changes Apr 29, 2023

View reviewed changes

KetuPatel806 and others added 2 commits April 29, 2023 19:17

Some Changed reflected

8890943

Merge branch 'pandas-dev:main' into main

1647697

MarcoGorelli suggested changes Apr 30, 2023

View reviewed changes

KetuPatel806 and others added 3 commits April 30, 2023 15:51

test_xml Updated

dcbe4dc

Merge branch 'main' of https://github.com/KetuPatel806/pandasContribu…

8d4a14b

…tion

Merge branch 'main' into main

86b89ea

MarcoGorelli reviewed Apr 30, 2023

View reviewed changes

KetuPatel806 added 2 commits April 30, 2023 16:03

Pre-commit check passed

b4d107b

Merge branch 'main' of https://github.com/KetuPatel806/pandasContribu…

56fef4d

…tion

MarcoGorelli suggested changes Apr 30, 2023

View reviewed changes

Mode changed in xml file

959dadc

MarcoGorelli reviewed Apr 30, 2023

View reviewed changes

mode reverted

7aebe05

Merge branch 'pandas-dev:main' into main

ba15d83

mroeschke added the Code Style Code style, linting, code_checks label May 1, 2023

KetuPatel806 added 2 commits May 2, 2023 17:22

Merge branch 'pandas-dev:main' into main

3e9ba30

Merge branch 'pandas-dev:main' into main

db8a984

KetuPatel806 and others added 4 commits May 5, 2023 19:03

Try to fix errors

c5fb9d6

Merge branch 'main' of https://github.com/KetuPatel806/pandasContribu…

743c63b

…tion

error-checks

d250a1d

Merge branch 'pandas-dev:main' into main

ea5c921

KetuPatel806 and others added 7 commits May 6, 2023 20:41

Fix Some errors

640e8e0

Merge branch 'pandas-dev:main' into main

27ff4bb

Unspecified-encodingFixed

98c004c

Merge branch 'main' of https://github.com/KetuPatel806/pandasContribu…

c18c670

…tion

Merge branch 'main' into main

d3f045d

final commited

513aebd

Merge branch 'main' of https://github.com/KetuPatel806/pandasContribu…

19a1eac

…tion

simplify

9128769

MarcoGorelli approved these changes May 7, 2023

View reviewed changes

MarcoGorelli merged commit 87970b2 into pandas-dev:main May 7, 2023

MarcoGorelli added this to the 2.1 milestone May 7, 2023

tqa236 mentioned this pull request May 19, 2023

STYLE: specify encodings when opening files #52963

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STYLE: specify encodings when opening files #52999

STYLE: specify encodings when opening files #52999

KetuPatel806 commented Apr 29, 2023 •

edited

Loading

MarcoGorelli commented Apr 29, 2023

KetuPatel806 commented Apr 29, 2023

MarcoGorelli left a comment

MarcoGorelli left a comment •

edited

Loading

MarcoGorelli Apr 29, 2023

KetuPatel806 Apr 29, 2023

KetuPatel806 Apr 29, 2023

MarcoGorelli left a comment

MarcoGorelli Apr 30, 2023

MarcoGorelli Apr 30, 2023

KetuPatel806 Apr 30, 2023

MarcoGorelli left a comment

MarcoGorelli Apr 30, 2023

MarcoGorelli Apr 30, 2023

MarcoGorelli Apr 30, 2023

MarcoGorelli commented Apr 30, 2023

KetuPatel806 commented May 2, 2023

MarcoGorelli commented May 2, 2023

KetuPatel806 commented May 2, 2023

MarcoGorelli commented May 2, 2023

MarcoGorelli commented May 5, 2023

KetuPatel806 commented May 5, 2023

KetuPatel806 commented May 6, 2023

KetuPatel806 commented May 7, 2023

MarcoGorelli left a comment

STYLE: specify encodings when opening files #52999

STYLE: specify encodings when opening files #52999

Conversation

KetuPatel806 commented Apr 29, 2023 • edited Loading

MarcoGorelli commented Apr 29, 2023

KetuPatel806 commented Apr 29, 2023

MarcoGorelli left a comment

Choose a reason for hiding this comment

MarcoGorelli left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoGorelli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoGorelli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoGorelli commented Apr 30, 2023

KetuPatel806 commented May 2, 2023

MarcoGorelli commented May 2, 2023

KetuPatel806 commented May 2, 2023

MarcoGorelli commented May 2, 2023

MarcoGorelli commented May 5, 2023

KetuPatel806 commented May 5, 2023

KetuPatel806 commented May 6, 2023

KetuPatel806 commented May 7, 2023

MarcoGorelli left a comment

Choose a reason for hiding this comment

KetuPatel806 commented Apr 29, 2023 •

edited

Loading

MarcoGorelli left a comment •

edited

Loading