-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
STYLE: specify encodings when opening files #52963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
take |
5 tasks
take |
4 tasks
any news about the task? @Aniket-Parlikar |
there's already an open pr... |
i can take it |
there is an opened PR already |
@MarcoGorelli I think #52999 (already merged) close this one, right? |
yup, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Opening a file without an encoding can cause issues on Windows, there's been some reports from people trying to contribute on Windows running into this
pylint has a check for this, so let's enable it (I've been learning some Rust, so I'll try to get it in to Ruff so it can run in a reasonable amount of time and we can later use that instead - but for now a manual pylint check is fine)
Task here is:
.pre-commit-config.yaml
pre-commit run unspecified-encoding --hook-stage manual --all-files
encoding='utf-8'
), stage, commit, push, open pull request, celebrateNo need to ask for permission to work on this:
take
and it will be assigned to youtake
a week has passed and they haven't done anything (a common occurrence, unfortunately), then feel free to take over. Please only commenttake
if you intend to work on thisThe text was updated successfully, but these errors were encountered: