STYLE: specify encodings when opening files #52963 #52997
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KetuPatel806
commented
Apr 29, 2023
•
KetuPatel806
commented
- closes STYLE: specify encodings when opening files #52963 (Replace STYLE: specify encodings when opening files #52963 with the GitHub issue number)
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
- Added type annotations to new arguments/methods/functions.
MarcoGorelli
changed the title
MarcoGorelli
suggested changes
Apr 29, 2023
| @@ -0,0 +1,432 @@ | |||
| minimum_pre_commit_version: 2.15.0 | |||
There was a problem hiding this comment.
what's this file? could you remove it please?
There was a problem hiding this comment.
if i remove it. it given some error instruction of that line.
There was a problem hiding this comment.
is there no need of b/.pre-commit-config.yaml this file??
.pre-commit-config.yaml
Outdated
Comment on lines
99
to
103
| - id: pylint | ||
| alias: unspecified-encoding | ||
| name: Using open without explicitly specifying an encoding | ||
| args: [--disable=all, --enable=unspecified-encoding] | ||
| stages: [manual] |
There was a problem hiding this comment.
could you keep the alignment that there is in the rest of the file?
There was a problem hiding this comment.
i think alignment are perfect for rest of the file
There was a problem hiding this comment.
pre-commit run unspecified-encoding --hook-stage manual which was skipped
There was a problem hiding this comment.
Suggested change
| - id: pylint | |
| alias: unspecified-encoding | |
| name: Using open without explicitly specifying an encoding | |
| args: [--disable=all, --enable=unspecified-encoding] | |
| stages: [manual] | |
| - id: pylint | |
| alias: unspecified-encoding | |
| name: Using open without explicitly specifying an encoding | |
| args: [--disable=all, --enable=unspecified-encoding] | |
| stages: [manual] |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.