Skip to content

CLN: Use #pragma once instead of include guards #52635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Apr 12, 2023

Shouldn't make any practical difference, but the include guards are a bit annoying and error prone to update if you move files around.

https://en.wikipedia.org/wiki/Pragma_once

@mroeschke mroeschke added this to the 2.1 milestone Apr 12, 2023
@mroeschke mroeschke merged commit 81b08a9 into pandas-dev:main Apr 12, 2023
@mroeschke
Copy link
Member

Thanks @WillAyd

@WillAyd WillAyd deleted the pragma-once branch April 12, 2023 23:41
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Apr 13, 2023
mroeschke added a commit that referenced this pull request Apr 14, 2023
* BUG: dt.days for timedelta non-nano overflows int32

* Run precommit

* lint

* Address code check failures

* Add whatsnew

* PERF: numpy dtype checks (#52582)

* CLN: Use #pragma once instead of include guards (#52635)

Use #pragma once

* Refactored custom datetime functions (#52634)

refactored custom datetime functions

* BLD: Add DLL hashes to RECORD (#52556)

* CI: Remove ArrayManager job (#52637)

* DOC: Remove notes to old Python/package versions (#52640)

* STYLE sort whatsnew entries alphabeticaly, allow for trailing full stops (#52598)

* allow for trailing full stops in sort-whatsnew-entries hook

* sort alphabetically instead

---------

Co-authored-by: MarcoGorelli <>

* Fix redundant entries

* remove redundant entries

---------

Co-authored-by: jbrockmendel <[email protected]>
Co-authored-by: William Ayd <[email protected]>
Co-authored-by: Thomas Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants