BLD: Add DLL hashes to RECORD #52556
Merged
+47
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 12, 2023
| for dll in required_dlls: | ||
| src = os.path.join(base_redist_dir, dll) | ||
| shutil.copy(src, dest_dll_dir) | ||
| subprocess.run(["wheel", "pack", tmp_dir, "-d", dest_dir], check=True) |
There was a problem hiding this comment.
Just curious, I see that wheel unpack will check the the hashes and file sizes and raise if there's a mismatch. Is it worth running that once after the packing is done?
There was a problem hiding this comment.
Nice suggestion. I hadn't thought about that.
It seems to do the right thing, since I get
wheel unpack pandas-2.0.0-cp310-cp310-win_amd64.whl
Unpacking to: pandas-2.0.0...No hash found for file 'pandas/_libs/window/msvcp140.dll'
when downloading the wheel and trying to unpack on macos.
mroeschke
approved these changes
Apr 12, 2023
|
Thanks for the review. Going to put this in now as failures are unrelated. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 13, 2023
phofl
pushed a commit
that referenced
this pull request
Apr 13, 2023
…52641) Backport PR #52556: BLD: Add DLL hashes to RECORD Co-authored-by: Thomas Li <[email protected]>
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Apr 13, 2023
mroeschke
added a commit
that referenced
this pull request
Apr 14, 2023
* BUG: dt.days for timedelta non-nano overflows int32 * Run precommit * lint * Address code check failures * Add whatsnew * PERF: numpy dtype checks (#52582) * CLN: Use #pragma once instead of include guards (#52635) Use #pragma once * Refactored custom datetime functions (#52634) refactored custom datetime functions * BLD: Add DLL hashes to RECORD (#52556) * CI: Remove ArrayManager job (#52637) * DOC: Remove notes to old Python/package versions (#52640) * STYLE sort whatsnew entries alphabeticaly, allow for trailing full stops (#52598) * allow for trailing full stops in sort-whatsnew-entries hook * sort alphabetically instead --------- Co-authored-by: MarcoGorelli <> * Fix redundant entries * remove redundant entries --------- Co-authored-by: jbrockmendel <[email protected]> Co-authored-by: William Ayd <[email protected]> Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandasusing poetry v1.4.1 #52465 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.