Refactored custom datetime functions #52634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
mroeschke
approved these changes
Apr 13, 2023
|
Thanks @WillAyd |
|
@jbrockmendel do you want to try #51368 again? I think the code you had there should translate perfectly into this |
|
My current thought/hope is that numpy will merge numpy/numpy#21199 and we'll get this function from them. If that falls through then I'll revisit #51368. |
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Apr 13, 2023
refactored custom datetime functions
|
Sounds good. Just keep in mind with that approach you won't ever be able to do what you were trying to do with using the DateTime API directly, so will just stick with the duck typing |
mroeschke
added a commit
that referenced
this pull request
Apr 14, 2023
* BUG: dt.days for timedelta non-nano overflows int32 * Run precommit * lint * Address code check failures * Add whatsnew * PERF: numpy dtype checks (#52582) * CLN: Use #pragma once instead of include guards (#52635) Use #pragma once * Refactored custom datetime functions (#52634) refactored custom datetime functions * BLD: Add DLL hashes to RECORD (#52556) * CI: Remove ArrayManager job (#52637) * DOC: Remove notes to old Python/package versions (#52640) * STYLE sort whatsnew entries alphabeticaly, allow for trailing full stops (#52598) * allow for trailing full stops in sort-whatsnew-entries hook * sort alphabetically instead --------- Co-authored-by: MarcoGorelli <> * Fix redundant entries * remove redundant entries --------- Co-authored-by: jbrockmendel <[email protected]> Co-authored-by: William Ayd <[email protected]> Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes some of our custom code out of the vendored numpy module and puts it in a capsule. date_conversions.c is custom and could argue it should entirely be put into the capsule, but didn't want to do that here.
The main motiviation is to make the work @jbrockmendel started in #51368 possible