Skip to content

CI: Test development container #52349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

theoniko
Copy link
Contributor

@theoniko theoniko commented Apr 1, 2023

@theoniko theoniko force-pushed the Test-development-container branch 6 times, most recently from e8b92df to 941dfc6 Compare April 1, 2023 19:36
@theoniko theoniko force-pushed the Test-development-container branch from 941dfc6 to ddc407b Compare April 2, 2023 07:56
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, but I am -0.5 on fully running the tests on the development container. We already run the test suite for other platforms on our CI which can take a while and the container is more of a development tool than a CI runner

@theoniko
Copy link
Contributor Author

theoniko commented Apr 4, 2023

the pull request, but I am -0.5 on fully running the tests on the development container. We already run the test suite for other platforms on our CI which can take a while and the container is more of a development tool than a CI runner

I agree with you point. Feature description says "The Docker dev environment test should be that it passes at least tests ran in the test_fast.sh file.". In issue 48537, test_fast.sh was used but the file was deleted in #48958. Shall i close this pr or do you see an alternative?

@mroeschke
Copy link
Member

I think we can close this PR and original issue as won't do.

@mroeschke mroeschke closed this Apr 4, 2023
@mroeschke mroeschke mentioned this pull request Apr 4, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Test development container
2 participants