Skip to content

ENH: Test development container #48537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
adrienpacifico opened this issue Sep 13, 2022 · 4 comments
Closed
3 tasks

ENH: Test development container #48537

adrienpacifico opened this issue Sep 13, 2022 · 4 comments
Labels
CI Continuous Integration Enhancement Testing pandas testing functions or related to the test suite

Comments

@adrienpacifico
Copy link
Contributor

adrienpacifico commented Sep 13, 2022

Feature Type

  • Adding new functionality to pandas

  • Changing existing functionality in pandas

  • Removing existing functionality in pandas

Problem Description

I am currently trying to set en development environment on a X86 Linux system by passing all test on my machine with a the provided Dockerfile.

The current development environment with this Dockerfile is not working since fast_test.sh is not passing.

image

This Dockerfile is tested in the CI to validate that it builds, and that it print the pandas versions :

build_docker_dev_environment:

However, this dev environment is not tested to determine if it can run all the unit tests.

Feature Description

The Docker dev environment test should be that it passes at least tests ran in the test_fast.sh file.

@adrienpacifico adrienpacifico added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 13, 2022
@lithomas1 lithomas1 added Testing pandas testing functions or related to the test suite CI Continuous Integration and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 13, 2022
@lithomas1 lithomas1 added this to the Contributions Welcome milestone Sep 13, 2022
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@theoniko
Copy link
Contributor

theoniko commented Apr 1, 2023

Hello @lithomas1, @mroeschke
I had a look to this issue. Does it mean we need to add add only the following in code-checks.yml
- name: Test
uses: ./.github/actions/run-tests
Does it need to run some other shell file called fast_test.sh? Btw such file does not exist...

@adrienpacifico
Copy link
Contributor Author

adrienpacifico commented Apr 4, 2023

@theoniko fast_test.sh has been deleted by #48958

Does it mean we need to add add only the following in code-checks.yml

I think that you need to do more than that, currently, if I launch the dev container from the GitHub URL, the test suite does not even start.

@theoniko
Copy link
Contributor

theoniko commented Apr 4, 2023

@adrienpacifico: I am sure about your feature request as @mroeschke commented in the PR 52349.

For the test suite you are right. I checked the logs and i see the problem
image

@mroeschke
Copy link
Member

For the test suite you are right. I checked the logs and i see the problem

That indicates that the C extensions have not been built

As mentioned in #52349 (review), the development container is just for development and is not used in our CI to set the environment and run tests necessarily so I think it would be overkill to also run the same tests in the container as the CI. I think the current check showing that the environment is available is sufficient so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Enhancement Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants