CLN: Replace test_fast scripts with documenting xdist n flag #48958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noatamir
added a commit
to noatamir/pandas
that referenced
this pull request
Oct 7, 2022
phofl
pushed a commit
that referenced
this pull request
Oct 14, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
noatamir
added a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_fastscripts were too heavily opinionated with all the flag settings and it's probably better we document the main functionality of how to parallelize using xdist (-n)Additionally removing the
Makefileas it's not documented as a development tool nor has it been properly updated to the state of pre-commit and other checks.