BUG/PERF: Series(category).replace #50857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Bug
Performance
lukemanley
commented
Jan 19, 2023
| not_included = removal_set - set(self.dtype.categories) | ||
| new_categories = [c for c in self.dtype.categories if c not in removal_set] | ||
|
|
||
| # GH 10156 |
There was a problem hiding this comment.
removed this GH ref as nan/NA categories are no longer allowed
mroeschke
approved these changes
Jan 24, 2023
|
Thanks for resubmitting @lukemanley |
pooja-subramaniam
pushed a commit
to pooja-subramaniam/pandas
that referenced
this pull request
Jan 25, 2023
* bug/perf: Series(category).replace * fixes * add test for replace with null * add test for GH46884
3 tasks
|
Could this have caused a performance regression? https://asv-runner.github.io/asv-collection/pandas/#categoricals.RemoveCategories.time_remove_categories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.0.0.rstfile if fixing a bug or adding a new feature.Redo of #49404 with fix that was reverted in #50848