Skip to content

Revert "BUG/PERF: Series.replace with dtype="category"" #50848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Revert "BUG/PERF: Series.replace with dtype="category"" #50848

merged 1 commit into from
Jan 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 18, 2023

Reverts #49404

@phofl phofl mentioned this pull request Jan 18, 2023
Merged
4 tasks
mroeschke
mroeschke approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops thanks for catching @phofl

@phofl
Copy link
Member Author

phofl commented Jan 18, 2023

circle ci is green, merging to get the other stuff running again

@phofl phofl added this to the 2.0 milestone Jan 18, 2023
@phofl phofl merged commit 305c938 into main Jan 18, 2023
@mroeschke mroeschke deleted the revert-49404-series-replace-categorical branch January 19, 2023 00:10
@lukemanley lukemanley mentioned this pull request Jan 19, 2023
Merged
6 tasks
pooja-subramaniam pushed a commit to pooja-subramaniam/pandas that referenced this pull request Jan 25, 2023
@phofl @pooja-subramaniam
Revert "BUG/PERF: Series.replace with dtype="category"" (pandas-dev#5…
cf93ee3 
…0848)

Revert "BUG/PERF: Series.replace with dtype="category" (pandas-dev#49404)"

This reverts commit a063af0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke