-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG/PERF: Series.replace with dtype="category" #49404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/PERF: Series.replace with dtype="category" #49404
Conversation
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM merge when ready @jbrockmendel
hopefully ill get time to take a good look this week but dont wait for me if this is a blocker. |
Thanks @lukemanley |
This broke the ci, opened #50848 to revert if there is no quick-win here |
…0848) Revert "BUG/PERF: Series.replace with dtype="category" (pandas-dev#49404)" This reverts commit a063af0.
doc/source/whatsnew/v2.0.0.rst
file if fixing a bug or adding a new feature.Refactor of
Categorical._replace
to fix a few bugs withSeries(..., dtype="category").replace
and improve performance.BUG 1: overlap between
to_replace
andvalue
:BUG 2: losing nullable dtypes of underlying categories:
Perf improvements:
"""