-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix bug in putmask for CoW #50630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @jorisvandenbossche Could you have a quick look? Ideally this would go into 1.5.3 |
# Conflicts: # pandas/tests/copy_view/test_methods.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Should we backport #50675 as well? |
Ah, forget what I said, the usage of |
Puuuuh, is there anything else that is scheduled for 1.5.3 regarding CoW? If not, I wouldn't backport I think |
Good :) |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.cc @jorisvandenbossche this did not work an 1.5.2