Skip to content

BUG: Series.quantile emitting RuntimeWarning for all NA case #50685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 12, 2023

I am not totally sure that we should backport since technically this also fixes a bug.

Edit: Could probably avoid the bug fix I guess

@phofl phofl added quantile quantile method NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Jan 12, 2023
@phofl phofl added this to the 1.5.3 milestone Jan 12, 2023
@phofl phofl added the Bug label Jan 12, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this interferes with anything that will be introduced in 2.0? If not, I'm fine backporting this bug fix

@phofl
Copy link
Member Author

phofl commented Jan 12, 2023

No the new behavior is correct (long term). So should be good to go

@mroeschke mroeschke merged commit 0597b15 into pandas-dev:main Jan 12, 2023
@mroeschke
Copy link
Member

Thanks @phofl

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 12, 2023
@phofl phofl deleted the 50681 branch January 12, 2023 21:26
phofl added a commit to phofl/pandas that referenced this pull request Jan 12, 2023
…dev#50685)

* BUG: Series.quantile emitting RuntimeWarning for all NA case

* Remove xfail
phofl added a commit that referenced this pull request Jan 13, 2023
…timeWarning for all NA case) (#50718)

Backport PR #50685: BUG: Series.quantile emitting RuntimeWarning for all NA case

Co-authored-by: Patrick Hoefler <[email protected]>
phofl added a commit that referenced this pull request Jan 13, 2023
phofl added a commit to phofl/pandas that referenced this pull request Jan 13, 2023
…dev#50685)

* BUG: Series.quantile emitting RuntimeWarning for all NA case

* Remove xfail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays quantile quantile method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: RuntimeWarning emitted when computing quantile on all pd.NA Series
2 participants