CLN: fix and move using_copy_on_write() helper out of internals #50675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
phofl
approved these changes
Jan 11, 2023
If that's OK for you, I would maybe merge this first? |
|
Yeah lets do it now |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially added this helper function just to the BlockManager internals in #49771, but since then it seems we also started to use it outside of the internals. Which I think is a good change for a check that we will have to do often on the short term (it makes it more convenient to do this check, see the improvement in the diff where I changed existing
get_option(..)calls).But, 1) the current function was only meant for internal usage and was incorrect for usage outside of the BlockManager (it also needs to check for the manager option) -> fixed that, and 2) moved it outside of the internals, so we don't have to import it from the internals in other parts of pandas.