Backport PR #50544 on branch 1.5.x (CI fix typing with latest ipython) #50555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumberbot-app
bot
added
CI
|
cc @MarcoGorelli Seems to be another typing failure |
MarcoGorelli
reviewed
Jan 4, 2023
|
the IPython and traitlets versions are the same on the 1.5.x branch, don't know why this is failing here but not on main, I can only put it down to it being a different mypy version. OK to |
|
Ok by me |
|
This might be failing on main https://github.com/pandas-dev/pandas/actions/runs/3838014340/jobs/6533977845 |
MarcoGorelli
force-pushed
the
auto-backport-of-pr-50544-on-1.5.x
branch
from
59c60aa to
72f66ba
Compare
|
yes, indeed - let's keep this to the first fix, and then backport #50562 too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #50544: CI fix typing with latest ipython