CI fix typing with latest ipython #50544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 4, 2023
| @@ -259,9 +259,10 @@ def enable_data_resource_formatter(enable: bool) -> None: | |||
| if mimetype not in formatters: | |||
| # define tableschema formatter | |||
| from IPython.core.formatters import BaseFormatter | |||
| from traitlets import ObjectName | |||
There was a problem hiding this comment.
We don't declare traitlets as a dependency as it comes from IPython?
datapythonista
added
CI
datapythonista
approved these changes
Jan 4, 2023
phofl
approved these changes
Jan 4, 2023
|
thx @MarcoGorelli |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 4, 2023
MarcoGorelli
added a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 4, 2023
MarcoGorelli
added a commit
that referenced
this pull request
Jan 4, 2023
#50555) Backport PR #50544: CI fix typing with latest ipython Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50543
ref
https://github.com/ipython/ipython/blob/01bc9d96e0dd50fad02d7b1e3d2e58113c617b6b/IPython/core/formatters.py#L777-L792