Skip to content

CI Ipython ci fixup again #50562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

CI Ipython ci fixup again #50562

merged 1 commit into from
Jan 4, 2023

Conversation

MarcoGorelli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli force-pushed the ipython-ci-fixup-again branch from d1dba01 to 55b517b Compare January 4, 2023 18:21
@MarcoGorelli
Copy link
Member Author

Looks like with ipython 8.8.0, it's necessary to # type: ignore this line, as opposed to 8.7.0 (that's the difference in the environments between today and yesterday):

                                                  Name Version_x Version_y
0    ──────────────────────────────────────────────...      None      None
61                                            cfn-lint    0.72.5    0.72.6
68                                            coverage     7.0.2     7.0.3
144                                           identify    2.5.11    2.5.12
151                                            ipython     8.7.0     8.8.0
169                                       jupyter_core     5.1.1     5.1.2
377                                              scipy     1.9.3    1.10.0
399                                         sqlalchemy    1.4.45    1.4.46

@MarcoGorelli MarcoGorelli mentioned this pull request Jan 4, 2023
Merged
@MarcoGorelli MarcoGorelli added this to the 1.5.3 milestone Jan 4, 2023
@MarcoGorelli MarcoGorelli added the CI Continuous Integration label Jan 4, 2023
mroeschke
mroeschke approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@phofl phofl merged commit 18bc585 into pandas-dev:main Jan 4, 2023
@phofl
Copy link
Member

phofl commented Jan 4, 2023

thx @MarcoGorelli

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 4, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 4, 2023
@MarcoGorelli @meeseeksmachine
Backport PR pandas-dev#50562: CI Ipython ci fixup again
473aee1
@rhshadrach
Copy link
Member

Probably due to ipython/ipython#13858

MarcoGorelli added a commit that referenced this pull request Jan 5, 2023
@meeseeksmachine @MarcoGorelli
Backport PR #50562 on branch 1.5.x (CI Ipython ci fixup again) (#50568)
108248e 
Backport PR #50562: CI Ipython ci fixup again

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcoGorelli @phofl @rhshadrach @mroeschke