Skip to content

CI: Test pandas warnings as error on some builds #50386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Dec 29, 2022

Conversation

mroeschke
Copy link
Member

Locally I was validating the recent addition of -W error:::pandas and had to change it to -W error:::$pandas so validating if the CI will raise as well

@mroeschke
Copy link
Member Author

So it appears the warning filter needs the fully qualified module name therefore we may need a way to generate all possible module paths in the library https://stackoverflow.com/a/73419829

@mroeschke mroeschke added CI Continuous Integration Warnings Warnings that appear or should be added to pandas labels Dec 28, 2022
@mroeschke mroeschke marked this pull request as ready for review December 28, 2022 00:59
@mroeschke mroeschke mentioned this pull request Dec 28, 2022
5 tasks
@mroeschke mroeschke added this to the 2.0 milestone Dec 28, 2022
@phofl phofl merged commit acd2f5f into pandas-dev:main Dec 29, 2022
@phofl
Copy link
Member

phofl commented Dec 29, 2022

Thx @mroeschke

@mroeschke mroeschke deleted the ci/warnings_test branch December 31, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants