TST:: Fixing pytest warning #50186
Closed
TST:: Fixing pytest warning #50186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 11, 2022
| @@ -1449,6 +1449,8 @@ def test_loc_bool_multiindex(self, dtype, indexer): | |||
| names=["a", "b"], | |||
| ) | |||
| df = DataFrame({"c": [1, 2, 3, 4]}, index=midx) | |||
| df.sort_index() | |||
There was a problem hiding this comment.
This has no effect. What are you trying to do?
There was a problem hiding this comment.
I thought i had to call sort_index as mentioned in
https://stackoverflow.com/questions/54307300/what-causes-indexing-past-lexsort-depth-warning-in-pandas
There was a problem hiding this comment.
sort_index returns a new object, as long as you ignore the new object, you will just continue operating on the unsorted object. In general, we don't want to call anything in tests that is not strictly necessary.
You have to understand where the warning is from. Then you can catch the warning or re-write the test so that the warning vanishes altogether. I guess that this is not possible here, but not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-W error:::pandasin pytest during CI runs #48553(Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.