Skip to content

CI: Fix npdev error on deprecation & future warnings #50452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 18, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Dec 27, 2022

As discovered in #50386, specifying modules in the warning filters need the fully qualified module path which numpy is not. In order to not enumerate all the modules paths in numpy, just have this build fail on any DeprecationWarning or FutureWarning

@mroeschke mroeschke added the CI Continuous Integration label Dec 27, 2022
@mroeschke mroeschke marked this pull request as draft December 28, 2022 19:25
@mroeschke mroeschke added this to the 2.0 milestone Jan 9, 2023
@mroeschke mroeschke marked this pull request as ready for review January 9, 2023 21:47
@mroeschke
Copy link
Member Author

Going to merge this. I think it's important we catch these new deprecation based warnings

@mroeschke mroeschke merged commit fe98101 into pandas-dev:main Jan 18, 2023
@mroeschke mroeschke deleted the ci/fix/np_dev_warnings branch January 18, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant