Skip to content

fix pylint bad-super-call #48896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/tests/extension/json/test_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class TestConstructors(BaseJSON, base.BaseConstructorsTests):
@pytest.mark.xfail(reason="not implemented constructor from dtype")
def test_from_dtype(self, data):
# construct from our dtype & string dtype
super(self).test_from_dtype(data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added in #46370 - I guess the error wasn't caught because the test is xfailed anyway?

cc @mroeschke in case you remember

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah before #46370, this test wasnt running I guess since there was a pass. Thanks for this cleanup

super().test_from_dtype(data)

@pytest.mark.xfail(reason="RecursionError, GH-33900")
def test_series_constructor_no_data_with_index(self, dtype, na_value):
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/extension/test_sparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def test_fillna_series_method(self, data_missing):
@pytest.mark.xfail(reason="Unsupported")
def test_fillna_series(self):
# this one looks doable.
super(self).test_fillna_series()
super().test_fillna_series()

def test_fillna_frame(self, data_missing):
# Have to override to specify that fill_value will change.
Expand Down
16 changes: 7 additions & 9 deletions pandas/tests/generic/test_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,27 +157,25 @@ def test_validate_bool_args(self, value):

msg = 'For argument "inplace" expected type bool, received type'
with pytest.raises(ValueError, match=msg):
super(DataFrame, df).rename_axis(
mapper={"a": "x", "b": "y"}, axis=1, inplace=value
)
super().rename_axis(mapper={"a": "x", "b": "y"}, axis=1, inplace=value)

with pytest.raises(ValueError, match=msg):
super(DataFrame, df).drop("a", axis=1, inplace=value)
super().drop("a", axis=1, inplace=value)

with pytest.raises(ValueError, match=msg):
super(DataFrame, df).fillna(value=0, inplace=value)
super().fillna(value=0, inplace=value)

with pytest.raises(ValueError, match=msg):
super(DataFrame, df).replace(to_replace=1, value=7, inplace=value)
super().replace(to_replace=1, value=7, inplace=value)

with pytest.raises(ValueError, match=msg):
super(DataFrame, df).interpolate(inplace=value)
super().interpolate(inplace=value)

with pytest.raises(ValueError, match=msg):
super(DataFrame, df)._where(cond=df.a > 2, inplace=value)
super()._where(cond=df.a > 2, inplace=value)

with pytest.raises(ValueError, match=msg):
super(DataFrame, df).mask(cond=df.a > 2, inplace=value)
super().mask(cond=df.a > 2, inplace=value)

def test_unexpected_keyword(self):
# GH8597
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ disable = [
"W",
"abstract-class-instantiated",
"access-member-before-definition",
"bad-super-call",

"c-extension-no-member",
"function-redefined",
"import-error",
Expand Down