TST: Fix warnings & skip -> xfail #46370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mroeschke
commented
Mar 15, 2022
mroeschke
commented
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
mroeschke
added
the
Testing
| @@ -523,7 +523,7 @@ def test_memory_usage(dtype): | |||
| # GH 33963 | |||
|
|
|||
| if dtype.storage == "pyarrow": | |||
| pytest.skip("not applicable") | |||
| pytest.skip(f"not applicable for {dtype.storage}") | |||
There was a problem hiding this comment.
this is a never-expected-to-change thing, i.e. shouldnt be an xfail?
There was a problem hiding this comment.
I assume so since I think that would require a pyarrow API to get memory usage (didn't see one quickly skimming)
| @@ -156,13 +156,9 @@ def test_reduce_series_numeric(self, data, all_numeric_reductions, skipna): | |||
|
|
|||
|
|
|||
| class TestMethods(base.BaseMethodsTests): | |||
| @pytest.mark.skip(reason="returns nullable") | |||
There was a problem hiding this comment.
yah really ought to pull the trigger on #44692 and just get internal consistency here
There was a problem hiding this comment.
Added that issue ref to this xfail
|
small questions on which ill trust your judgement. LGTM. |
|
the pytest plugins i cant comment on but the rest LGTM |
jreback
reviewed
Mar 15, 2022
| @@ -56,6 +56,7 @@ markers = [ | |||
| "arm_slow: mark a test as slow for arm64 architecture", | |||
| "arraymanager: mark a test to run with ArrayManager enabled", | |||
| ] | |||
| asyncio_mode = "strict" | |||
There was a problem hiding this comment.
We have some tab completion tests that use this
(pandas-dev) ... % grep --include="*.py" "async def" pandas/tests -r
pandas/tests/resample/test_resampler_grouper.py:async def test_tab_complete_ipython6_warning(ip):
pandas/tests/frame/test_api.py: async def test_tab_complete_warning(self, ip, frame_or_series):
pandas/tests/arrays/categorical/test_warnings.py: async def test_tab_complete_warning(self, ip):
pandas/tests/indexes/test_base.py: async def test_tab_complete_warning(self, ip):
|
@meeseeksdev backport 1.4.x |
This comment was marked as resolved.
This comment was marked as resolved.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Mar 29, 2022
(cherry picked from commit 60cc2f3)
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.