fix pylint bad-super-call #48896
Merged
fix pylint bad-super-call #48896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
soumilbaldota
commented
Sep 30, 2022
soumilbaldota
commented
- updates STYLE fix pylint issues #48855
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
MarcoGorelli
suggested changes
Oct 2, 2022
1 task
Co-authored-by: Marco Edward Gorelli <[email protected]>
…/pandas into bad-super-call-fix
MarcoGorelli
approved these changes
Oct 6, 2022
| @@ -159,7 +159,7 @@ class TestConstructors(BaseJSON, base.BaseConstructorsTests): | |||
| @pytest.mark.xfail(reason="not implemented constructor from dtype") | |||
| def test_from_dtype(self, data): | |||
| # construct from our dtype & string dtype | |||
| super(self).test_from_dtype(data) | |||
There was a problem hiding this comment.
this was added in #46370 - I guess the error wasn't caught because the test is xfailed anyway?
cc @mroeschke in case you remember
There was a problem hiding this comment.
Yeah before #46370, this test wasnt running I guess since there was a pass. Thanks for this cleanup
mroeschke
approved these changes
Oct 6, 2022
|
Thanks @soumilbaldota |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* fix pylint bad-super-call * fix black pre commit * Update pyproject.toml Co-authored-by: Marco Edward Gorelli <[email protected]> * change super() to df.copy() Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.