-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: value_counts consistently return int64 dtype #44692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jbrockmendel
commented
Nov 30, 2021
- closes API: value_counts with nullable dtype should return np.int64 like everything else #44679
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's first discuss this further at #44679
when was the change added to make these EA types in the first place, was it for 1.4? |
This is already the behaviour since at least 1.0 (checked it for Int64 for that version) |
ahh then this would be hard to change actually (as its the return type) |
its all still marked as experimental |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
no apparent interest here, closing. |