Skip to content

API: value_counts consistently return int64 dtype #44692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

jbrockmendel
Copy link
Member

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first discuss this further at #44679

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. labels Dec 24, 2021
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

when was the change added to make these EA types in the first place, was it for 1.4?

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jan 8, 2022

This is already the behaviour since at least 1.0 (checked it for Int64 for that version)

@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

This is already the behaviour since at least 1.0 (checked it for Int64 for that version)

ahh then this would be hard to change actually (as its the return type)

@jbrockmendel
Copy link
Member Author

ahh then this would be hard to change actually (as its the return type)

its all still marked as experimental

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Feb 14, 2022
@jbrockmendel
Copy link
Member Author

no apparent interest here, closing.

@jbrockmendel jbrockmendel deleted the api-vcs-int64 branch November 23, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: value_counts with nullable dtype should return np.int64 like everything else
4 participants