Skip to content

REF: Move value_counts, take, factorize to ArrowExtensionArray #46453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 28, 2022
Merged

REF: Move value_counts, take, factorize to ArrowExtensionArray #46453

merged 6 commits into from
Mar 28, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 21, 2022 •
edited
Loading

@jbrockmendel
Copy link
Member

These are all methods for which we're effectively just dispatching to pyarrow's native implementations?

@mroeschke
Copy link
Member Author

These are all methods for which we're effectively just dispatching to pyarrow's native implementations?

Correct, effectively dispatches to ChunkArray.value_counts and pc.is_in

@mroeschke mroeschke changed the title REF: Move value_counts, isin to ArrowExtensionArray REF: Move value_counts to ArrowExtensionArray Mar 21, 2022
@mroeschke mroeschke added the Arrow pyarrow functionality label Mar 21, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 21, 2022
@mroeschke
Copy link
Member Author

isin needs better thought around dtype. Probably need to create an ArrowExtensionType or something

@mroeschke mroeschke changed the title REF: Move value_counts to ArrowExtensionArray REF: Move value_counts, take, factorize to ArrowExtensionArray Mar 28, 2022
@jreback jreback merged commit 58a2069 into pandas-dev:main Mar 28, 2022
@mroeschke mroeschke deleted the ref/arrowextention/methods branch March 28, 2022 19:38
@jbrockmendel
Copy link
Member

As ArrowExtensionArray becomes more of The Default, i think it becomes increasingly important to address #45419. Is __setitem__ (or other setitem-like ops) going to Break The World?

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
REF: Move value_counts, take, factorize to ArrowExtensionArray (panda…
e91e28c 
…s-dev#46453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Arrow pyarrow functionality
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jbrockmendel @jreback