BUG: DTI.intersection with DST transition #48167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Timezones
pandas/core/indexes/datetimes.py
Outdated
| if self.tz is not None and not timezones.is_utc(self.tz): | ||
| return False | ||
| other_tz = getattr(other, "tz", None) | ||
| if other_tz is not None and not timezones.is_utc(other_tz): |
There was a problem hiding this comment.
fine if you want to do quick fix, but could also include fixed-offset tzs. also i think we're assured matching types/dtypes at this point
There was a problem hiding this comment.
Added a check for not timezones.is_fixed_offset.
Yeah I think a more complete check would be to add a .fold attribute and then check self.fold.nunique > 1. That would allow some DatetimeIndexes to still use the distpatch to range ops. #47130
jorisvandenbossche
approved these changes
Aug 20, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 21, 2022
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 22, 2022
…ansition) (#48189) Backport PR #48167: BUG: DTI.intersection with DST transition Co-authored-by: Matthew Roeschke <[email protected]>
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* BUG: DTI.intersection with DST transition * Add whatsnew note * Add fixed offset as well
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatetimeIndex.intersectionnot working for localized indices #46702 (Replace xxxx with the Github issue number)doc/source/whatsnew/v1.4.4.rstfile if fixing a bug or adding a new feature.