-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: DTI.intersection with DST transition #48167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 7 commits into
pandas-dev:main
from
mroeschke:bug/dti_intersection_dst
Aug 21, 2022
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9c9c78d
BUG: DTI.intersection with DST transition
mroeschke 1eeb281
Merge remote-tracking branch 'upstream/main' into bug/dti_intersectio…
mroeschke 8db8949
Add whatsnew note
mroeschke 68d856c
Merge remote-tracking branch 'upstream/main' into bug/dti_intersectio…
mroeschke 3c86515
Add fixed offset as well
mroeschke ab5924e
Merge remote-tracking branch 'upstream/main' into bug/dti_intersectio…
mroeschke 253f1a6
Merge remote-tracking branch 'upstream/main' into bug/dti_intersectio…
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine if you want to do quick fix, but could also include fixed-offset tzs. also i think we're assured matching types/dtypes at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a check for
not timezones.is_fixed_offset
.Yeah I think a more complete check would be to add a
.fold
attribute and then checkself.fold.nunique > 1
. That would allow someDatetimeIndex
es to still use the distpatch to range ops. #47130