-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Move whatsnew for indexing regression #47924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes. would do this as a follow up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phofl ok to merge this once #47921 is merged. see #47921 (review)
urgh I should have left it in otherwise we will get more conflicts if we have to move the release note for that one. don't merge this yet. although i'm doing something else at the moment (fixing the typing on 1.4.x) so probably won't fix this till tomorrow. |
No worries, added it back in |
Thanks. sorry for interfering. I thought it'd be quicker to just resolve the conflicts on the web interface than ping you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phofl merge when ready
No worries. I am doing this in Pycharm anyway, so did not create additional work for me. Thanks for helping |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Don't have to backport this |
* DOC: Move whatsnew for indexing regression * Change whatsnew * Add whatsnew back in Co-authored-by: Simon Hawkins <[email protected]>
xref #47921, #47867 (comment)
Moves the whatsnew