Backport PR #47905: BUG: Fix read_xml raising syntax error when reading XML with Chinese tags #47925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when reading XML with Chinese tags
simonjayhawkins
requested changes
Aug 3, 2022
There was a problem hiding this comment.
Thanks @ParfaitG we should await a response to #47905 (comment). Personally i'm not keen on backporting but will defer to @mroeschke on that.
|
IMO I would say the code changes here shouldn't be risky. But since this affects a feature that was added only since in 1.4, for peace of mind I think it's okay if this applies to 1.5. @ParfaitG would you mind instead changing this PR to only moving the whatsnew note for this change from 1.4.4 to 1.5? |
5 tasks
this PR is against 1.4.x where the move only needs to happen on main if I close this backport now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Backport #47905
doc/source/whatsnew/v1.4.4.rstfile if fixing a bug or adding a new feature.