Backport PR #45287 on branch 1.4.x (BUG: frame[x].loc[y] inconsistent with frame.at[x, y]) (#45287) #47921
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-dev#45287) Co-authored-by: Jeff Reback <[email protected]>
phofl
changed the title
simonjayhawkins
added
Indexing
|
don't worry about the mypy failures. imo it is main that is wrong since we have traditionally always run the typing validation against the latest numpy release, which is what's happening here. |
|
Yep thx |
Thanks @phofl merge when ready. |
doc/source/whatsnew/v1.4.4.rst
Outdated
| @@ -16,6 +16,7 @@ Fixed regressions | |||
| ~~~~~~~~~~~~~~~~~ | |||
| - Fixed regression in :func:`concat` materializing :class:`Index` during sorting even if :class:`Index` was already sorted (:issue:`47501`) | |||
| - Fixed regression in setting ``None`` or non-string value into a ``string``-dtype Series using a mask (:issue:`47628`) | |||
| - Fixed regression in :meth:`loc.__getitem__` with a list of keys causing an internal inconsistency that could lead to a disconnect between ``frame.at[x, y]`` vs ``frame[y].loc[x]`` (:issue:`22372`) | |||
There was a problem hiding this comment.
I would probably move this to bug fix and put reference to the new issue in the regression section
There was a problem hiding this comment.
I would also add a release note for the #47867 issue in the regression section (in the addition to the bugfix release note)
or are you doing this when you add the test?
There was a problem hiding this comment.
Wanted to do this with the test, but no strong preference
|
Failure unrelated, see #47945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #45287, see #47867 (comment)
Lets see if this works