BUG FIX: incorrect type when casting to nullable type in multiindex dataframe #47419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2022 19:10
mroeschke
added
MultiIndex
NA - MaskedArrays
mroeschke
reviewed
Aug 15, 2022
| @@ -227,3 +227,17 @@ def test_multiindex_repeated_keys(self): | |||
| ], | |||
| Series([1, 1, 2, 2], MultiIndex.from_arrays([["a", "a", "b", "b"]])), | |||
| ) | |||
|
|
|||
| @pytest.mark.parametrize("data_type", ["int64", "int32", "float64", "float32"]) | |||
There was a problem hiding this comment.
I think this should use any_signed_int_ea_dtype
mroeschke
reviewed
Aug 15, 2022
| @@ -11917,6 +11917,11 @@ def _reindex_for_setitem(value: DataFrame | Series, index: Index) -> ArrayLike: | |||
| # reindex if necessary | |||
|
|
|||
| if value.index.equals(index) or not len(index): | |||
| if isinstance(value, DataFrame): | |||
| dtype_list = value.dtypes.unique() | |||
There was a problem hiding this comment.
I think this should use find_common_type
Ok I will close my PR. Your PR is much better. Will look at your solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.