-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG FIX: incorrect type when casting to nullable type in multiindex dataframe #47419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3689528
add
29b3a92
Merge branch 'main' of https://github.com/weikhor/pandas into 46896_m…
8cf01ef
add dataframe
5323e09
add test
aa50dd9
Merge branch 'main' into 46896_multiindex_dataframe
c6c22fe
Merge branch 'main' into 46896_multiindex_dataframe
8e60f61
Merge branch 'main' into 46896_multiindex_dataframe
ee94440
Merge branch 'main' into 46896_multiindex_dataframe
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,3 +227,17 @@ def test_multiindex_repeated_keys(self): | |
], | ||
Series([1, 1, 2, 2], MultiIndex.from_arrays([["a", "a", "b", "b"]])), | ||
) | ||
|
||
@pytest.mark.parametrize("data_type", ["int64", "int32", "float64", "float32"]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should use |
||
def test_multiindex_dataframe_incorrect_type(self, data_type): | ||
# GH 46896 | ||
df = DataFrame( | ||
columns=MultiIndex.from_tuples([("a", "c"), ("a", "d")]), | ||
data=[[1, 2], [3, 4]], | ||
) | ||
df["a"] = df["a"].astype(data_type) | ||
|
||
result = df.dtypes | ||
expected = Series(data=[data_type, data_type], index=[["a", "a"], ["c", "d"]]) | ||
|
||
tm.assert_series_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should use
find_common_type