Skip to content

Assigning with partial indexing on columns and mixed type unnecessarily upcasts #20476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toobaz opened this issue Mar 23, 2018 · 2 comments · Fixed by #48094
Closed

Assigning with partial indexing on columns and mixed type unnecessarily upcasts #20476

toobaz opened this issue Mar 23, 2018 · 2 comments · Fixed by #48094
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Milestone

Comments

@toobaz
Copy link
Member

toobaz commented Mar 23, 2018

Code Sample, a copy-pastable example if possible

In [2]: df = pd.DataFrame(-1, index=range(3), columns=pd.MultiIndex.from_product([['A', 'B'], ['a', 'b', 'c']]))

In [3]: filler = pd.DataFrame([[1, 2, 3.]]*3, index=range(3), columns=['a', 'b', 'c'])

In [4]: filler
Out[4]: 
   a  b    c
0  1  2  3.0
1  1  2  3.0
2  1  2  3.0

In [5]: df['A'] = filler

In [6]: df
Out[6]: 
     A            B      
     a    b    c  a  b  c
0  1.0  2.0  3.0 -1 -1 -1
1  1.0  2.0  3.0 -1 -1 -1
2  1.0  2.0  3.0 -1 -1 -1

Problem description

Only one of the three columns had float dtype, but the two others have been upcasted.

My guess is that somewhere a .values is used inappropriately.

Expected Output

In [6]: df
Out[6]: 
   A          B      
   a  b    c  a  b  c
0  1  2  3.0 -1 -1 -1
1  1  2  3.0 -1 -1 -1
2  1  2  3.0 -1 -1 -1

Output of pd.show_versions()

INSTALLED VERSIONS

commit: None
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.9.0-5-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.UTF-8
LOCALE: it_IT.UTF-8

pandas: 0.23.0.dev0+653.g7273ea070
pytest: 3.2.3
pip: 9.0.1
setuptools: 38.5.2
Cython: 0.25.2
numpy: 1.14.1
scipy: 0.19.0
pyarrow: None
xarray: None
IPython: 6.2.1
sphinx: 1.5.6
patsy: 0.5.0
dateutil: 2.7.0
pytz: 2017.2
blosc: None
bottleneck: 1.2.0dev
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.0
openpyxl: 2.3.0
xlrd: 1.0.0
xlwt: 1.3.0
xlsxwriter: 0.9.6
lxml: 4.1.1
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: 0.2.1

@jreback
Copy link
Contributor

jreback commented Mar 26, 2018

ok, might be tricky, setting is pretty messing inside

@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves Dtype Conversions Unexpected or buggy dtype conversions MultiIndex Difficulty Intermediate labels Mar 26, 2018
@jreback jreback added this to the Next Major Release milestone Mar 26, 2018
@proost
Copy link
Contributor

proost commented Oct 5, 2019

No one working on, Could i look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants