TST,WARN: read_csv raises warning at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail #47387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
added
the
Warnings
mroeschke
approved these changes
Jun 23, 2022
mroeschke
reviewed
Jun 23, 2022
yes, probably, thanks should this be backported too, as it affects legibility of warnings to do with an upcoming deprecation? |
Yeah I think this would be okay to backport cc @simonjayhawkins |
sure. there's a bug fix section in the 1.4.4 release notes. |
mroeschke
approved these changes
Jun 25, 2022
This comment was marked as resolved.
This comment was marked as resolved.
MarcoGorelli
added a commit
to MarcoGorelli/pandas
that referenced
this pull request
Jun 26, 2022
…ong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail
simonjayhawkins
pushed a commit
that referenced
this pull request
Jul 2, 2022
…g at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail )" (#47513)
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…ised_with_correct_stacklevel doesn't fail (pandas-dev#47387) * fix stacklevel of read_csv warning * :doc: add whatsnewnote * move whatsnew entry to v1.4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.