Skip to content

TST,WARN: read_csv raises warning at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail #47387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 26, 2022
Merged

TST,WARN: read_csv raises warning at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail #47387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
28129e4
fix stacklevel of read_csv warning
MarcoGorelli Jun 16, 2022
1b2cc15
Merge branch 'main' into fix-read_csv-stacklevel-warning
MarcoGorelli Jun 16, 2022
a5e8d20
Merge branch 'main' into fix-read_csv-stacklevel-warning
MarcoGorelli Jun 19, 2022
cd7b04b
Merge branch 'main' into fix-read_csv-stacklevel-warning
MarcoGorelli Jun 23, 2022
e53e30c
:doc: add whatsnewnote
MarcoGorelli Jun 24, 2022
0335607
Merge remote-tracking branch 'upstream/main' into fix-read_csv-stackl…
MarcoGorelli Jun 24, 2022
f1d8d87
move whatsnew entry to v1.4.4
MarcoGorelli Jun 25, 2022
51208ec
Merge remote-tracking branch 'upstream/main' into fix-read_csv-stackl…
MarcoGorelli Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.4.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Fixed regressions

Bug fixes
~~~~~~~~~
-
- The :class:`errors.FutureWarning` raised when passing arguments (other than ``filepath_or_buffer``) as positional in :func:`read_csv` is now raised at the correct stacklevel (:issue:`47385`)
-

.. ---------------------------------------------------------------------------
Expand Down
4 changes: 1 addition & 3 deletions pandas/io/parsers/readers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,9 +829,7 @@ def read_csv(
...


@deprecate_nonkeyword_arguments(
version=None, allowed_args=["filepath_or_buffer"], stacklevel=3
)
@deprecate_nonkeyword_arguments(version=None, allowed_args=["filepath_or_buffer"])
@Appender(
_doc_read_csv_and_table.format(
func_name="read_csv",
Expand Down
3 changes: 1 addition & 2 deletions pandas/tests/io/parser/common/test_common_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,7 @@ def test_read_csv_posargs_deprecation(all_parsers):
"In a future version of pandas all arguments of read_csv "
"except for the argument 'filepath_or_buffer' will be keyword-only"
)
with tm.assert_produces_warning(FutureWarning, match=msg):
parser.read_csv(f, " ")
parser.read_csv_check_warnings(FutureWarning, msg, f, " ")


@pytest.mark.parametrize("delimiter", [",", "\t"])
Expand Down