TST,WARN: read_csv raises warning at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail (pandas-dev#47387)

MarcoGorelli · yehoshuadimarsky · commit 9700b423c2e5 · 2022-07-13T10:18:05.000-04:00
* fix stacklevel of read_csv warning

* :doc: add whatsnewnote

* move whatsnew entry to v1.4.4
diff --git a/doc/source/whatsnew/v1.4.4.rst b/doc/source/whatsnew/v1.4.4.rst
@@ -23,7 +23,7 @@ Fixed regressions
 
 Bug fixes
 ~~~~~~~~~
--
+- The :class:`errors.FutureWarning` raised when passing arguments (other than ``filepath_or_buffer``) as positional in :func:`read_csv` is now raised at the correct stacklevel (:issue:`47385`)
 -
 
 .. ---------------------------------------------------------------------------
diff --git a/pandas/io/parsers/readers.py b/pandas/io/parsers/readers.py
@@ -829,9 +829,7 @@ def read_csv(
     ...
 
 
-@deprecate_nonkeyword_arguments(
-    version=None, allowed_args=["filepath_or_buffer"], stacklevel=3
-)
+@deprecate_nonkeyword_arguments(version=None, allowed_args=["filepath_or_buffer"])
 @Appender(
     _doc_read_csv_and_table.format(
         func_name="read_csv",
diff --git a/pandas/tests/io/parser/common/test_common_basic.py b/pandas/tests/io/parser/common/test_common_basic.py
@@ -806,8 +806,7 @@ def test_read_csv_posargs_deprecation(all_parsers):
         "In a future version of pandas all arguments of read_csv "
         "except for the argument 'filepath_or_buffer' will be keyword-only"
     )
-    with tm.assert_produces_warning(FutureWarning, match=msg):
-        parser.read_csv(f, " ")
+    parser.read_csv_check_warnings(FutureWarning, msg, f, " ")
 
 
 @pytest.mark.parametrize("delimiter", [",", "\t"])

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ Fixed regressions`
`23`	`23`
`24`	`24`	`Bug fixes`
`25`	`25`	`~~~~~~~~~`
`26`		`--`
	`26`	+- The :class:`errors.FutureWarning` raised when passing arguments (other than ``filepath_or_buffer``) as positional in :func:`read_csv` is now raised at the correct stacklevel (:issue:`47385`)
`27`	`27`	`-`
`28`	`28`
`29`	`29`	`.. ---------------------------------------------------------------------------`
Original file line number	Diff line number	Diff line change
`@@ -806,8 +806,7 @@ def test_read_csv_posargs_deprecation(all_parsers):`
`806`	`806`	`"In a future version of pandas all arguments of read_csv "`
`807`	`807`	`"except for the argument 'filepath_or_buffer' will be keyword-only"`
`808`	`808`	`)`
`809`		`- with tm.assert_produces_warning(FutureWarning, match=msg):`
`810`		`- parser.read_csv(f, " ")`
	`809`	`+ parser.read_csv_check_warnings(FutureWarning, msg, f, " ")`
`811`	`810`
`812`	`811`
`813`	`812`	`@pytest.mark.parametrize("delimiter", [",", "\t"])`