Skip to content

TST: GH38947 creating function to test bar plot index #46451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2022

Conversation

Daquisu
Copy link
Contributor

@Daquisu Daquisu commented Mar 20, 2022

I just implemented all changes done by @SabrinaMD

But I updated the small corrections

@Daquisu Daquisu force-pushed the test/plot-bar-index branch from 11cc850 to 6765339 Compare March 21, 2022 00:19
@Daquisu
Copy link
Contributor Author

Daquisu commented Mar 21, 2022

FAILED pandas/tests/io/parser/test_parse_dates.py::test_hypothesis_delimited_date[%m %Y-True-.]

From here. Does it mean that it failed because of a test in test_parse_dates.py? If so, isn't it weird since I only edited the file in pandas/tests/plotting/test_misc.py?

@Daquisu
Copy link
Contributor Author

Daquisu commented Mar 21, 2022

There are also 4 error messages, all the same:

Error: The runner has received a shutdown signal...' in GHA. GH 45651
Error: The runner has received a shutdown signal...' in GHA. GH 45651
Error: The runner has received a shutdown signal...' in GHA. GH 45651
Error: The runner has received a shutdown signal...' in GHA. GH 45651

From GH 45651 it seems the test pandas/tests/io/parser/test_parse_dates.py::test_hypothesis_delimited_date is causing GHA to crash? If so what would be the solution?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Apr 21, 2022
@Daquisu
Copy link
Contributor Author

Daquisu commented Apr 21, 2022 via email

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Visualization plotting and removed Stale labels Apr 24, 2022
@mroeschke mroeschke added this to the 1.5 milestone Apr 24, 2022
@mroeschke mroeschke merged commit 2e56a83 into pandas-dev:main Apr 24, 2022
@mroeschke
Copy link
Member

Thanks @Daquisu, sorry for the long delay. (The CI failure was unrelated). Happy to have more PRs with regression tests!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* TST: GH38947 creating function to test bar plot index

* TST: GH38947 removing try/except since assert will raise appropriately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR: Barplot broken on Index(dtype='object')
2 participants