Skip to content

REGR: Barplot broken on Index(dtype='object') #44033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

SabrinaMB
Copy link

@pep8speaks
Copy link

pep8speaks commented Oct 14, 2021

Hello @SabrinaMB! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-14 20:20:54 UTC

@alimcmaster1 alimcmaster1 added Testing pandas testing functions or related to the test suite Visualization plotting labels Oct 14, 2021
@alimcmaster1
Copy link
Member

Thanks for the PR @SabrinaMB , please could you fix the flake8 issues below as per CI.

MIght be worth reading our contributing guide here: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html

Please could you also update the PR title to something more descriptive.

Thanks!

flake8..........................................................................................................Failed
- hook id: flake8
- exit code: 1

pandas/tests/plotting/test_misc.py:470:20: C407 Unnecessary list comprehension - 'all' can take a generator.
pandas/tests/plotting/test_misc.py:476:9: F841 local variable 'e' is assigned to but never used

@jreback jreback changed the title Issue38947 REGR: Barplot broken on Index(dtype='object') Oct 16, 2021
@jreback
Copy link
Contributor

jreback commented Nov 14, 2021

can you merge master and update to comments

1 similar comment
@jreback
Copy link
Contributor

jreback commented Nov 28, 2021

can you merge master and update to comments

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 29, 2021
@mroeschke
Copy link
Member

Thanks for the PR, but it appears to have gone stale. If interested in continuing please merge the main branch and address the review and we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR: Barplot broken on Index(dtype='object')
5 participants